fix: restore support for deprecated WORKER_REGION env var #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jusiskin
changed the title
jusiskin
previously approved these changes
Jun 7, 2024
epmog
previously approved these changes
Jun 7, 2024
Signed-off-by: Trevor Blanchard <[email protected]>
ttblanchard
force-pushed
the
fix_worker_region_shim
branch
from
fe25490 to
3b45ad5
Compare
|
jusiskin
approved these changes
Jun 7, 2024
epmog
approved these changes
Jun 7, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
WORKER_REGION should have had a deprecation notice before throwing an exception when used.
What was the solution? (How)
Adding a temporary shim
What is the impact of this change?
Having
WORKER_REGIONset in the environment wont cause an exception to be thrown.How was this change tested?
Was this change documented?
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.