test: Set AWS_ENDPOINT_URL_DEADLINE on Worker #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moorec-aws
force-pushed
the
moorec/add_worker_endpoint
branch
from
14b3573 to
b71436f
Compare
Signed-off-by: Charles Moore <[email protected]>
moorec-aws
force-pushed
the
moorec/add_worker_endpoint
branch
from
b71436f to
9f7a37b
Compare
|
jericht
approved these changes
Jun 6, 2024
jusiskin
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
In #96 we added functionality to specify and use
AWS_ENDPOINT_URL_DEADLINEto set a custom endpoint url. We do not currently set this env variable on the workers so that it can connect to designated endpointWhat was the solution? (How)
Added the following to the worker configuration:
If the environment variable is specified, then add it to the Worker before installation so that it connects to the intended endpoint/farm location.
What is the impact of this change?
Enables AWS_ENDPOINT_URL_DEADLINE usage for the Worker Agent.
How was this change tested?
Setting
AWS_ENDPOINT_URL_DEADLINEand runninghatch run integ-testi confirmed that the worker would connect to various endpoints.Was this change documented?
no
Is this a breaking change?
no
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.