feat! Create a script to build adaptor package artifacts #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiebe
force-pushed
the
markw/packaging-artifact
branch
from
34282a2 to
d5733aa
Compare
epmog
approved these changes
Feb 9, 2024
jericht
reviewed
Feb 11, 2024
jericht
approved these changes
Feb 11, 2024
mwiebe
force-pushed
the
markw/packaging-artifact
branch
2 times, most recently
from
f51f824 to
ca95f2d
Compare
The breaking change is due to updating the adaptor runtime dependency to 0.4 - Also deprecate the binary name NukeAdaptor, and add the name nuke-openjd - Update the adaptor runtime dependency to 0.4, and fix up socket path into server path - Update the submitter to provide both Rez and Conda packages metadata. The Rez package names are the same for now to keep backwards compatibility. - Fix up the adaptor to not require the deadline-cloud library - Remove the TelemetryOptOut job parameter. This clutters the UI by putting it as a job parameter, and we should add a config file that a Queue Environment can control for this instead. - Fix some corner cases in the job bundle output test normalization, so that it passes on Windows. - Reduced the test coverage requirement from 73 to 72. It rounded off to being equal to 73 but still failed. Signed-off-by: Mark Wiebe <[email protected]>
mwiebe
force-pushed
the
markw/packaging-artifact
branch
from
ca95f2d to
3ca4a41
Compare
epmog
approved these changes
Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We have designed a new structure for how we lay out application interface adaptors into packages. In order to simplify the packaging step, we'll put a script that generates an artifact with that layout into each adaptor git repo.
In order to perform the layout we wanted, I needed to modify the adaptor runtime. Those changes are in OpenJobDescription/openjd-adaptor-runtime-for-python#69
The adaptor runtime dependency was out of date, After updating, it required changes from a socket_path to a server_path parameter.
What was the solution? (How)
What is the impact of this change?
The repo has a script that can generate a .tar archive containing a prefix layout of the adaptor python library and its dependencies, along with an entry point.
How was this change tested?
The generated .tar archive was used to create a package, and that was tested on a Deadline Cloud farm.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Yes.
Was this change documented?
No
Is this a breaking change?
Yes, it updates the openjd adaptor runtime dependency which had a breaking change.