Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add optional purpose enum to bundle creation callback. #50

Open
wants to merge 1 commit into
base: mainline
Choose a base branch
from

Conversation

rmv
Copy link
Contributor

@rmv rmv commented Oct 26, 2023

What was the problem/requirement? (What/Why)

Make Nuke submitter compatible with new purpose argument in job bundle creation callback.

What was the solution? (How)

Import the type and add the optional argument.

What is the impact of this change?

Make submitter compatible with additional deadline-cloud changes.

How was this change tested?

Tests pass and it compiles (requires changes in aws-deadline/deadline-cloud#94

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Minor change

Was this change documented?

No

Is this a breaking change?

No

@rmv rmv requested a review from a team as a code owner October 26, 2023 22:22
@rmv
Copy link
Contributor Author

rmv commented Oct 26, 2023

NB: this will fail until aws-deadline/deadline-cloud#94 is in.

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants