feat: Handle different OCIO configs in adapter #168
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We need to support multiple ways of specifying an OCIO config. The adapter was failing on anything but custom configs.
What was the solution? (How)
Change the assumptions that
get_custom_config_path
was the best way to get the OCIO config.What is the impact of this change?
The adapter supports multiple ways of specifying an OCIO config.
How was this change tested?
NUKE_ADAPTOR_NUKE_EXECUTABLE=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/MacOS/Nuke15.0 nuke-openjd run --init-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/init-data.yaml --run-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/run-data.yaml
aces_1.2
)OCIO=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/Resources/OCIOConfigs/configs/aces_1.2/config.ocio NUKE_ADAPTOR_NUKE_EXECUTABLE=/Applications/Nuke15.0v4/Nuke15.0v4.app/Contents/MacOS/Nuke15.0 nuke-openjd run --init-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/init-data.yaml --run-data file:///Users/sbanas/dev/deadline-clients/deadline-cloud-for-nuke/run-data.yaml
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Was this change documented?
No. Is there a place that needs to be updated?
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.