Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update frame range when write node is selected #161

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

diane-hj
Copy link
Contributor

This is the same PR from #154
The commit was merged in during release window, so got reverted. The PR is to re-merge the changes back.

What was the problem/requirement? (What/Why)

When write node is selected, incorrect frame range were exported in parameters

What was the solution? (How)

  • When override frame is selected, override the frame
  • When write node is selected with limit_range checked (without override), write node's frame applied
  • When write node is selected without limit_range checked (without override), project settings frame applied
  • When no specific write node is selected, project settings frame applied

What is the impact of this change?

  • Based on the customers' setting, right frame range is selected as explained above

How was this change tested?

  • Opened Nuke with the following setting:
Project setting frame: 1-4
Write1 node frame: 1-10
Override when selected with frame: 4

Verified the following:

All write nodes, without frame override —> 1 - 4 
All write nodes, with frame override —> 4 
All write nodes, without frame override —> 1 - 4

Write1, with limitRange, without frame override —> 1 - 10 
Write1, with limitRange, with frame override —> 4
Write1, with limitRange, without frame override —> 1- 10 

Write1, without limitRange, without frame override —> 1- 4
Write1, without limitRange, with frame override —> 4 
Write1, without limitRange, without frame override —> 1 - 4 

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.


Timestamp: 2024-08-12T14:01:24.012286-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/group-read

group-read
Test succeeded

Timestamp: 2024-08-12T14:01:25.055533-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/noise-saver

noise-saver
Test succeeded

Timestamp: 2024-08-12T14:01:26.720246-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/multi-load-save

multi-load-save
Test succeeded

Timestamp: 2024-08-12T14:01:27.757395-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/frame

frame
Test succeeded

Timestamp: 2024-08-12T14:01:29.360422-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/ocio

ocio
Test succeeded

Timestamp: 2024-08-12T14:01:30.340508-07:00
Running job bundle output test: /Users/chaejung/Desktop/submitter/deadline-cloud-for-nuke/job_bundle_output_tests/cwd-path

cwd-path
Test succeeded

All tests passed, ran 6 total.
Timestamp: 2024-08-12T14:01:33.469925-07:00

Was this change documented?

No

Is this a breaking change?

This is fix.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@diane-hj diane-hj requested a review from a team as a code owner August 21, 2024 18:16
Copy link

Copy link
Contributor

@Cherie-Chen Cherie-Chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the PR!

@diane-hj diane-hj merged commit e6398c9 into aws-deadline:mainline Aug 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants