-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add ability to configure timeouts in submission UI #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AWS-Samuel
force-pushed
the
add-timeouts
branch
3 times, most recently
from
May 15, 2024 17:18
783216a
to
9f3684c
Compare
AWS-Samuel
force-pushed
the
add-timeouts
branch
3 times, most recently
from
May 16, 2024 18:41
f14fb78
to
995c1d3
Compare
epmog
reviewed
May 17, 2024
src/deadline/nuke_submitter/ui/components/scene_settings_tab.py
Outdated
Show resolved
Hide resolved
epmog
previously approved these changes
May 17, 2024
crowecawcaw
reviewed
May 21, 2024
crowecawcaw
reviewed
May 21, 2024
epmog
reviewed
May 21, 2024
epmog
previously approved these changes
May 21, 2024
AWS-Samuel
force-pushed
the
add-timeouts
branch
5 times, most recently
from
May 22, 2024 14:55
eed1e36
to
183e7b9
Compare
crowecawcaw
reviewed
May 23, 2024
src/deadline/nuke_submitter/ui/components/scene_settings_tab.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Samuel Anderson <[email protected]>
Quality Gate passedIssues Measures |
crowecawcaw
approved these changes
May 23, 2024
epmog
approved these changes
May 24, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There was no mechanism to set timeouts for session/environment actions through the submitter.
What was the solution? (How)
Add the UI. The default looks like the following:
A warning pops up when deselecting the
Use Timeouts
checkboxZero-valued timeouts are not valid, and are highlighted red to help with identification
The timeout fields are disabled when the
Use Timeouts
checkbox is not selectedWhat is the impact of this change?
Users can set timeouts in their job and have the corresponding action timeout when the duration has elapsed.
How was this change tested?
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Yes, I updated the job bundle output test job templates as the default value for the timeout fields has changed the expected template
Was this change documented?
Yes
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.