Skip to content

Commit

Permalink
fix: include description on submission (#89)
Browse files Browse the repository at this point in the history
Signed-off-by: Morgan Epp <[email protected]>
  • Loading branch information
epmog authored Feb 13, 2024
1 parent d5f3d12 commit 13b4a56
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 4 deletions.
5 changes: 5 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -14,3 +14,8 @@ __pycache__/
dependency_bundle
**/test_job_bundle/
**/test-job-bundle-results.txt
.DS_Store
dev_install
.exe
.run

4 changes: 3 additions & 1 deletion src/deadline/nuke_submitter/deadline_submitter_for_nuke.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,10 @@ def _get_job_template(settings: RenderSubmitterUISettings) -> dict[str, Any]:
with open(Path(__file__).parent / "default_nuke_job_template.yaml") as f:
job_template = yaml.safe_load(f)

# Set the job's name
# Set the job's name and description
job_template["name"] = settings.name
if settings.description:
job_template["description"] = settings.description

# Get a map of the parameter definitions for easier lookup
parameter_def_map = {param["name"]: param for param in job_template["parameterDefinitions"]}
Expand Down
7 changes: 4 additions & 3 deletions src/deadline/nuke_submitter/job_bundle_output_test_runner.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,13 +170,14 @@ def run_render_submitter_job_bundle_output_test():
report_fh.write(f"Failed {count_failed} tests, succeeded {count_succeeded}.\n")
nuke.alert(
"Some Job Bundle Tests Failed\n\n"
f"Failed {count_failed} tests, succeeded {count_succeeded}.\n"
f"See the file {test_job_bundle_results_file} for a full report.",
f"Failed {count_failed} tests, succeeded {count_succeeded}.\n\n"
f'See the file "{test_job_bundle_results_file}" for a full report.',
)
else:
report_fh.write(f"All tests passed, ran {count_succeeded} total.\n")
nuke.message(
f"All Job Bundle Tests Passed\n\nRan {count_succeeded} tests in total.",
f"All Job Bundle Tests Passed\n\nRan {count_succeeded} tests in total.\n\n"
f'See the file "{test_job_bundle_results_file}" for a full report.',
)
report_fh.write(f"Timestamp: {_timestamp_string()}\n")

Expand Down

0 comments on commit 13b4a56

Please sign in to comment.