Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: libtoml -> tomllib in depsBundle.py #89

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

AWS-Samuel
Copy link
Contributor

What was the problem/requirement? (What/Why)

We used the wrong package name for python 3.11

What was the solution? (How)

Use tomllib, ref: https://docs.python.org/3/library/tomllib.html

What is the impact of this change?

We can run depsBundle.py in python 3.11

How was this change tested?

I imported tomllib in 3.11:

(24-02-08 19:56:44) % python -c "import tomllib"

(24-02-08 19:56:47) % python -c "import libtoml"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
ModuleNotFoundError: No module named 'libtoml'

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

No because this does not affect integration code.

Was this change documented?

No

Is this a breaking change?

No

@AWS-Samuel AWS-Samuel requested a review from a team as a code owner February 8, 2024 19:57
@AWS-Samuel AWS-Samuel merged commit a477805 into mainline Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants