feat: Add support for renderman job attachments. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmv
force-pushed
the
MayaRendermanSubmitter
branch
from
820a581 to
b28a687
Compare
Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
rmv
force-pushed
the
MayaRendermanSubmitter
branch
from
b28a687 to
0e87b77
Compare
Add test for new code Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
cleanup Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
cleanup Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
ttblanchard
approved these changes
Feb 14, 2024
| from maya.cmds import filePathEditor # type: ignore | ||
| from rfm2.txmanager_maya import get_texture_by_path # type: ignore | ||
|
|
||
| # cmds.filePathEditor().return_value = ['0', '1'] |
There was a problem hiding this comment.
Can we clean up these comment if not needed (also on line 58)
AWS-Samuel
reviewed
Feb 14, 2024
… comments Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
|
Also fixed an issue where the original textures were not being added. |
Signed-off-by: Ramon Montoya Vozmediano <[email protected]>
AWS-Samuel
approved these changes
Feb 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
As part of support for renderman the maya submitter needs to find the correct renderman job attachments
What was the solution? (How)
Query Maya's repathing tool for external resources, and get the .tex filenames through Renderman's Tx Manager.
What is the impact of this change?
Should find Renderman job attachments if the renderman render is selected in render settings when submitting.
How was this change tested?
Tried different renderman scenes and checked the output job bundles, which included the original and tex files.
Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.
Yes, the tests passed correctly.
Was this change documented?
Not yet, once all the parts are in.
Is this a breaking change?
No.