Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(submitter): Enable capability UI for Maya Submitter #33

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

tincheng
Copy link
Contributor

What was the problem/requirement? (What/Why)

deadline cloud has implemented a new host requirements tab that should be enabled in each DCC submitters.

What was the solution? (How)

Enable host requirements UI for Maya submitter.

Note: The custom requirements buttons are none reactive at time of this PR. The feature will be updated through deadline-cloud.

What is the impact of this change?

Users should be able to see a new tab for "Host Requirements", and capabilities selected will reflect in job bundle history on submit/export.

How was this change tested?

Screenshot 2023-10-10 at 5 44 53 PM
steps:
- name: masterLayer
......
  script:
    embeddedFiles:
    - name: runData
      filename: run-data.yaml
      type: TEXT
      data: |
        frame: {{Task.Param.Frame}}
        camera: '{{Task.Param.Camera}}'
    actions:
      onRun:
        command: MayaAdaptor
        args:
        - daemon
        - run
        - --connection-file
        - '{{ Session.WorkingDirectory }}/connection.json'
        - --run-data
        - file://{{ Task.File.runData }}
        cancelation:
          mode: NOTIFY_THEN_TERMINATE
  hostRequirements:
    attributes:
    - name: attr.worker.os.family
      anyOf:
      - linux
    - name: attr.worker.cpu.arch
      anyOf:
      - x86_64
    amounts:
    - name: amount.worker.vcpu
      min: 6

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

Yes, but the tests failed with empty result.txt. May be an issue of running the tests on Mac.

Required: paste the contents of job_bundle_output_tests/test-job-bundle-results.txt here

Was this change documented?

No

Is this a breaking change?

No

@tincheng tincheng requested a review from a team as a code owner October 11, 2023 01:04
@tincheng tincheng force-pushed the tincheng/capabilities branch from 99a10c6 to f033fdf Compare October 11, 2023 01:11
@tincheng tincheng changed the title Enable capability UI for Maya Submitter feat(submitter): Enable capability UI for Maya Submitter Oct 11, 2023
@agerveshi
Copy link
Contributor

We should add a job bundle output test that includes the hostRequirements.

@tincheng tincheng merged commit 6b50bcb into mainline Oct 19, 2023
5 checks passed
@tincheng tincheng deleted the tincheng/capabilities branch October 19, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants