Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps)!: Update to openjd-runtime-adaptor #32

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

agerveshi
Copy link
Contributor

@agerveshi agerveshi commented Oct 6, 2023

BEA-16122

What was the problem/requirement? (What/Why)

deadline and openjd dependencies needed to be updated as there are breaking changes in the backend.

What was the solution? (How)

move to latest deadline and move to openjd-adaptor-runtime as openjd has been deprecated.

What is the impact of this change?

Maya job submissions will work again

How was this change tested?

  • Unit tests pass
  • Successfully submitted an arnold job to the farm

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.

The tests are failing because RenderSetupIncludeLight is false, but this seems to be a user-specific setting. I will investigate further.

Timestamp: 2023-10-06T19:58:19.951958+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: deadline:targetTaskRunStatus
   value: READY
 - name: deadline:maxFailedTasksCount

Timestamp: 2023-10-06T19:58:20.279787+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -46,7 +46,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Timestamp: 2023-10-06T19:58:20.890610+00:00
Running job bundle output test: /home/rocky/src/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test failed, found differences
--- expected/parameter_values.yaml
+++ test/parameter_values.yaml
@@ -14,7 +14,7 @@
 - name: OutputFilePath
   value: /normalized/job/bundle/dir/images
 - name: RenderSetupIncludeLights
-  value: 'true'
+  value: 'false'
 - name: ArnoldErrorOnLicenseFailure
   value: 'false'
 - name: deadline:targetTaskRunStatus

Failed 3 tests, succeeded 0.
Timestamp: 2023-10-06T19:58:23.452759+00:00

Was this change documented?

Yes, updated repo documentation

Is this a breaking change?

Yes, breaking dependency changes

@agerveshi agerveshi changed the title Update dependencies and fix failing unit tests chore(deps)!: Update dependencies and fix failing unit tests Oct 6, 2023
@agerveshi agerveshi changed the title chore(deps)!: Update dependencies and fix failing unit tests chore(deps)!: Update to openjd-runtime-adaptor Oct 6, 2023
@agerveshi agerveshi marked this pull request as ready for review October 6, 2023 20:11
@agerveshi agerveshi requested a review from a team as a code owner October 6, 2023 20:11
Signed-off-by: Alex Gerveshi <[email protected]>
Signed-off-by: Alex Gerveshi <[email protected]>
Signed-off-by: Alex Gerveshi <[email protected]>
@agerveshi agerveshi force-pushed the agerveshi/16122/openjd-runtime-adaptor branch from 7d59587 to 2e3c8ce Compare October 10, 2023 21:10
@agerveshi agerveshi merged commit a51edc8 into mainline Oct 11, 2023
5 checks passed
@agerveshi agerveshi deleted the agerveshi/16122/openjd-runtime-adaptor branch October 11, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants