Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include description in job submission #188

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

benl-2023
Copy link
Contributor

What was the problem/requirement? (What/Why)

  • Maya job submissions were not including the description field, even when filled out in the submitter UI.

What was the solution? (How)

  • Include the description

What is the impact of this change?

  • Jobs submitted with the maya submitter will include the description when populated

How was this change tested?

Ran the submitter with a local installation of Maya and verified newly submitted jobs include the description field in the Deadline Cloud Monitor.

  • Have you run the unit tests?
    Yes

Did you run the "Job Bundle Output Tests"? If not, why not? If so, paste the test results here.


Timestamp: 2024-10-24T11:20:44.903849-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/layers

layers
Test succeeded

Timestamp: 2024-10-24T11:20:46.045940-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/referenced_layers

referenced_layers
Test succeeded

Timestamp: 2024-10-24T11:20:46.501578-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/renderman
Skipping test renderman because Renderman for Maya is not installed.
Timestamp: 2024-10-24T11:20:46.501665-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/cube

cube
Test succeeded

Timestamp: 2024-10-24T11:20:47.150117-07:00
Running job bundle output test: /Users/larbe/github/deadline-cloud-for-maya/job_bundle_output_tests/layers_no_variation

layers_no_variation
Test succeeded

All tests passed, ran 4 total.
Timestamp: 2024-10-24T11:20:54.336125-07:00

Was this change documented?

N/A

Is this a breaking change?

No


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@benl-2023 benl-2023 requested a review from a team as a code owner October 24, 2024 18:23
@benl-2023 benl-2023 added the bug Something isn't working label Oct 24, 2024
Copy link

@leongdl leongdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM trivial fix

@leongdl
Copy link

leongdl commented Oct 24, 2024

Ben you did not git commit -s

Copy link

@leongdl leongdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did not pass DCO, git commit -s

@benl-2023 benl-2023 enabled auto-merge (squash) October 25, 2024 17:00
Copy link

@benl-2023 benl-2023 merged commit c279cfd into aws-deadline:mainline Oct 25, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants