fix: adaptor wheel override #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaseck
approved these changes
Jun 28, 2024
Signed-off-by: Leon Li <[email protected]>
AuxinJeron
force-pushed
the
fix-adaptor-wheel-override
branch
from
ee90a35 to
159ed84
Compare
crowecawcaw
approved these changes
Jul 1, 2024
github-actions bot
pushed a commit
to Ahuge/deadline-cloud-for-maya
that referenced
this pull request
Jul 2, 2024
Signed-off-by: Leon Li <[email protected]> Co-authored-by: Leon Li <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The adaptor wheel override was broken by a change in deadline-cloud which made it so that PATH Job Parameter defaults can't be absolute paths. The way the adaptor wheel directory was being added to the template was by adding in a new job parameter with a default value of what was specified by the user. This would result in an error like below on submission:
What was the solution? (How)
Remove the setting of the default value of the AdaptorWheel Job Parameter and instead set it when the other Job Parameters.
What is the impact of this change?
The adaptor wheel override works again
How was this change tested?
Tested with and without the adaptor wheel override set and verified in the jobs that were run that the adaptors were overridden or not.
Was this change documented?
No
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.