Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove merge back from release workflow #102

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

moorec-aws
Copy link
Contributor

What was the problem/requirement? (What/Why)

  1. Using merge back requires a removal of a security feature
  2. Pushing to release before merging the change log makes rolling back awkward if there is an issue found in the changelog PR.

What was the solution? (How)

release:bump no longer merges, it only create the PR for the change log. release:publish now runs when a push is made to mainline with a modification to CHANGELOG.md. If the commit was made by ci, then it will merge mainline to release and follow with the release and publish jobs.

What is the impact of this change?

Should make release process smoother

How was this change tested?

Tested in a developer github account

Was this change documented?

no

Is this a breaking change?

no

@moorec-aws moorec-aws requested a review from a team as a code owner February 23, 2024 20:00
@moorec-aws moorec-aws merged commit 1bc5945 into mainline Feb 23, 2024
6 checks passed
@moorec-aws moorec-aws deleted the moorec/no-mergeback branch February 23, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants