-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ksp bundling #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crowecawcaw
reviewed
Jul 5, 2024
lucaseck
force-pushed
the
add_ksp_bundling
branch
4 times, most recently
from
July 10, 2024 02:56
fc7b729
to
c787abd
Compare
lucaseck
force-pushed
the
add_ksp_bundling
branch
2 times, most recently
from
July 10, 2024 03:05
00dc50f
to
948384d
Compare
crowecawcaw
previously approved these changes
Jul 10, 2024
Signed-off-by: lucaseck <[email protected]>
lucaseck
force-pushed
the
add_ksp_bundling
branch
from
July 11, 2024 16:52
000384a
to
40a85e4
Compare
crowecawcaw
reviewed
Jul 11, 2024
crowecawcaw
reviewed
Jul 11, 2024
crowecawcaw
approved these changes
Jul 11, 2024
ryyakobe
approved these changes
Jul 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
There was no pathmapping support with KeyShot.
What was the solution? (How)
One way around this is to bundle a scene up as a KeyShot Package(ksp) which creates a zipped archive of the scene file and any external file references. The scene within is modified to have relative paths to all of the referenced files.
This PR adds a submission mode selector for:
What is the impact of this change?
KeyShot can be used without having to deal with manually packing/unpacking ksps or setting up network storage
How was this change tested?
Was this change documented?
Only in the README
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.