Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support ksp bundling #97

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

lucaseck
Copy link
Contributor

@lucaseck lucaseck commented Jul 5, 2024

What was the problem/requirement? (What/Why)

There was no pathmapping support with KeyShot.

What was the solution? (How)

One way around this is to bundle a scene up as a KeyShot Package(ksp) which creates a zipped archive of the scene file and any external file references. The scene within is modified to have relative paths to all of the referenced files.

This PR adds a submission mode selector for:

  1. Just submit the scene .bip file and all files referenced within will have to be available through network storage or some other means
  2. Automatically save the current scene as a ksp to a temp directory, unpack it and then submit the modified scene and assets from the unpacked ksp where all paths are relative

What is the impact of this change?

KeyShot can be used without having to deal with manually packing/unpacking ksps or setting up network storage

How was this change tested?

  • Ran all unit tests including newly included ones
  • Ran submissions using both submission modes and verified the outputs
  • Tested canceling the dialog, and the sticky setting of which option was selected

Was this change documented?

Only in the README

Is this a breaking change?

No

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lucaseck lucaseck requested a review from a team as a code owner July 5, 2024 18:59
@lucaseck lucaseck marked this pull request as draft July 5, 2024 18:59
@lucaseck lucaseck changed the title Draft: feat: support ksp bundling feat: support ksp bundling Jul 5, 2024
@lucaseck lucaseck force-pushed the add_ksp_bundling branch 4 times, most recently from fc7b729 to c787abd Compare July 10, 2024 02:56
@lucaseck lucaseck marked this pull request as ready for review July 10, 2024 02:57
@lucaseck lucaseck force-pushed the add_ksp_bundling branch 2 times, most recently from 00dc50f to 948384d Compare July 10, 2024 03:05
crowecawcaw
crowecawcaw previously approved these changes Jul 10, 2024
@lucaseck lucaseck merged commit df141f5 into aws-deadline:mainline Jul 11, 2024
9 checks passed
@lucaseck lucaseck deleted the add_ksp_bundling branch July 11, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants