feat!: update licensing configuration and instructions #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Eckhardt <[email protected]>
epmog
approved these changes
Mar 30, 2024
marofke
approved these changes
Mar 30, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We were making assumptions that KeyShot licenses would be available from a licensing tunnel configured to 2703@localhost. This isn't super flexible for users to configure their own licensing.
What was the solution? (How)
Remove the hardcoded
@localhostand instead provide instructions for setting up licensing using the environment variableLUXION_LICENSE_FILEWhat is the impact of this change?
Easier and more flexible setup for licensing with the KeyShot adaptor
How was this change tested?
Configured licensing on a Windows machine by setting the environment variable and running the adaptor to verify that it could pull a KeyShot license from my configured floating license server
Was this change documented?
No
Is this a breaking change?
If someone was relying on localhost being assumed for licensing then yes