Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add install builder component #5

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

lucaseck
Copy link
Contributor

@lucaseck lucaseck commented Feb 9, 2024

What was the problem/requirement? (What/Why)

  • To include the KeyShot submitter in the installer an install builder component is needed

What was the solution? (How)

  • Added the install builder component
  • Added the dependency bundle script
  • Added clearer warnings for the ENV variables needed to open the submitter

What is the impact of this change?

  • KeyShot should be able to be built into the installer

How was this change tested?

  • Built an installer using the new component and verified the installation in Windows

Was this change documented?

No

Is this a breaking change?

No

@lucaseck lucaseck force-pushed the lucaseck-install-builder-component branch from 48ed088 to 88c6275 Compare February 9, 2024 22:20
@lucaseck lucaseck merged commit 7c4e2b8 into mainline Feb 12, 2024
2 checks passed
@lucaseck lucaseck deleted the lucaseck-install-builder-component branch February 12, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants