Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update README adaptor instructions #24

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

lucaseck
Copy link
Contributor

What was the problem/requirement? (What/Why)

  • Adaptor instructions in the README were missing a step that the KeyShot executable needs to be on the path
  • Two set commands included quotes which should not have

What was the solution? (How)

  • Made the changes to the README

What is the impact of this change?

Easier to setup the KeyShot adaptor

How was this change tested?

N/A

Was this change documented?

N/A

Is this a breaking change?

No

@lucaseck lucaseck requested a review from a team as a code owner February 27, 2024 22:19
@lucaseck lucaseck force-pushed the lucaseck/readme_adaptor_updates branch from ddd6fe9 to b50bf5e Compare February 27, 2024 22:22
Copy link

@erico-aws erico-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucaseck lucaseck merged commit 4b6d201 into mainline Feb 28, 2024
12 checks passed
@lucaseck lucaseck deleted the lucaseck/readme_adaptor_updates branch February 28, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants