fix!: use keyshot-openjd in submitter #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joel-wong-aws
force-pushed
the
keyshot_openjd
branch
from
ae84798 to
0c7fd85
Compare
baxeaz
approved these changes
Dec 11, 2024
karthikbekalp
approved these changes
Dec 11, 2024
Signed-off-by: Joel Wong <[email protected]>
joel-wong-aws
force-pushed
the
keyshot_openjd
branch
from
0c7fd85 to
8d784f4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
We currently use
KeyshotAdaptoras the entry point to running Keyshot on Windows by default. TheKeyshotAdaptorentry point is deprecated in favour ofkeyshot-openjd(code link)What was the solution? (How)
Updated the template to use
keyshot-openjdinstead ofKeyshotAdaptorWhat is the impact of this change?
Removal of deprecated code.
How was this change tested?
Submitted a job against an updated Keyshot Conda package which supported
keyshot-openjd. Confirmed that the job ran successfully.Also ran
hatch clean && hatch build && hatch run fmt && hatch run lint && hatch run testWas this change documented?
No, N/A
Is this a breaking change?
Yes. This uses a different entry point to the Keyshot adaptor than previous revisions. If customers wish to continue to use
KeyshotAdaptor, they can update references tokeyshot-openjdinSubmit to AWS Deadline Cloudback toKeyShotAdaptor.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.