fix: use consistent version strings for Keyshot #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <[email protected]>
|
joel-wong-aws
approved these changes
Oct 2, 2024
AuxinJeron
approved these changes
Oct 2, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The Keyshot adapter prints out the Keyshot version number as 13.0.0 instead of 2024.1. The version numbers are equivalent, but are confusing when the submitter and conda packages use the second version scheme.
Fixes: #119
What was the solution? (How)
Update the version number scheme to be consistent.
What is the impact of this change?
Clearer logs.
How was this change tested?
I ran just the changed lines in Keyshot and saw that it printed:
Was this change documented?
Not needed.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.