feat: speedup KSP extraction on Windows #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wonjoel <[email protected]>
|
lucaseck
approved these changes
Aug 29, 2024
crowecawcaw
approved these changes
Aug 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
It was noted that progress reporting dramatically affected the speed of zip extraction using
Expand-Archivein Windows PowerShell.What was the solution? (How)
While progress reporting is nice to have, so is fast submission speed. I tested extraction times with the sample Keyframe Animation (robot head) scene from KeyShot and discovered that extraction time was sped up by 2.5x when progress reporting was not used. From previous experience, the speedup can up to 4x depending on the size of files, the machine used, etc.
We believe that customers value fast unzipping much more than progress reporting while unzipping, so I have applied the speedup by default.
What is the impact of this change?
Speedup of submission using Deadline Cloud for KeyShot.
How was this change tested?
Used this with the KeyFrame Animation scene form KeyShot and confirmed it worked.
Was this change documented?
No, not required
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.