fix: remove submitter dependencies that aren't available in KeyShot Python #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython Signed-off-by: wonjoel <[email protected]>
joel-wong-aws
force-pushed
the
remove_submitter_dependencies
branch
from
244a06a to
43d9fc7
Compare
|
crowecawcaw
approved these changes
Aug 28, 2024
epmog
approved these changes
Aug 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
Addresses #107
What was the solution? (How)
Replaced each of the unavailable libraries with alternate approaches.
Note that any OS which can run KeyShot 2023 or 2024 can run
unzip(Mac) orExpand-Archive(Windows).What is the impact of this change?
Customers are able to submit in KeyShot Python.
How was this change tested?
Uninstalled system Python 3.11 from my (Windows) machine. Submitted jobs with and without the external file options.
Also tested from a Mac machine.
Was this change documented?
No, not required.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.