fix: add default values for conda packages and channels #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <[email protected]>
lucaseck
reviewed
Aug 28, 2024
Signed-off-by: Stephen Crowe <[email protected]>
|
joel-wong-aws
approved these changes
Aug 29, 2024
lucaseck
approved these changes
Aug 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
The CLI-based submitter should provide defaults for conda if the queue has a conda queue environment,
What was the solution? (How)
Add defaults.
What is the impact of this change?
The submitter works easily with conda without fiddling with conda settings.
How was this change tested?
I submitted a job that used the defaults to a queue that had the default queue environment and it worked. I also tested it with a queue that did not have a queue environment.
Was this change documented?
Not needed.
Is this a breaking change?
No, it adds back a feature that's been missing since the submitter refactor. Note: it defaults to a different Keyshot version scheme that the old defaults.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.