feat: submitter prompts user to save changes before submitting #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stephen Crowe <[email protected]>
lucaseck
reviewed
Jul 10, 2024
Signed-off-by: Stephen Crowe <[email protected]>
lucaseck
approved these changes
Jul 10, 2024
epmog
approved these changes
Jul 10, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the problem/requirement? (What/Why)
If the user makes updates to their scene but fails to save them before submitting, their local changes won't be part of the submission.
What was the solution? (How)
Detect when there are unsaved changes and prompt the user to save their file first.
What is the impact of this change?
Local changes are always saved before submitting.
How was this change tested?
Local testing and a unit test.
Was this change documented?
No, not needed.
Is this a breaking change?
No
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.