Support EBS attached ECS tasks #69
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script check-ecs-exec.sh currently encounters a subnet ID parsing error when used with ECS tasks that have EBS volumes attached. The error arises because the script incorrectly assumes that the attachments array includes only network interfaces.
The check-ecs-exec.sh script is designed to parse only ElasticNetworkInterface from the attachments array returned by the aws ecs describe-tasks command. If an ECS task has an EBS volume attached, the array might also contain AmazonElasticBlockStorage objects, which can lead to incorrect parsing if these are listed before any network interfaces.
Update the parsing logic within check-ecs-exec.sh to accurately handle multiple types of attachments, focusing specifically on ElasticNetworkInterface objects for subnet ID extraction. This ensures the script disregards any AmazonElasticBlockStorage objects or other non-network-related attachments that could interfere with the correct parsing process.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.