Fix formatting round trip - Style is always 0

[ericzbeard]

When formatting to JSON and back to YAML, JSON styles were left in the YAML nodes, which caused inconsistent formatting.

This might be considered a breaking change, because one of the effects is to now format !Sub without double quotes, even if they were in the original.

Fixes #170

[ericzbeard]

Can't add you as an official review but please take a look if you have time @hariprakash-j @iainelder

[hariprakash-j]

@ericzbeard , is there any reason why the input yaml files are inline and in its own file ? if for some reason it needs to be changed would it not be confusing to change the same thing in two places? Wouldn't it be better to read the file and remove the inline to keep the data in one place.

[hariprakash-j]

just a small thing, in the file format_test.go the function checkMatch has the input var coded inside the function instead of it being an arg to the function, passing in the input as an arg would make it more reusable if some one wants to use it later with a different input.

[ericzbeard]

@ericzbeard , is there any reason why the input yaml files are inline and in its own file ? if for some reason it needs to be changed would it not be confusing to change the same thing in two places? Wouldn't it be better to read the file and remove the inline to keep the data in one place.

I only added the separate file so I could see the output directly from the command, outside of unit tests. The file isn't actually being used for anything else.

[ericzbeard]

just a small thing, in the file format_test.go the function checkMatch has the input var coded inside the function instead of it being an arg to the function, passing in the input as an arg would make it more reusable if some one wants to use it later with a different input.

Yep, I'll change that if I need to add any more tests in the future.

[hariprakash-j]

everything its okay, just noticed those two things 👍