Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix:update specification of claude v2 modelid #234

Conversation

sho-saito
Copy link
Contributor

@sho-saito sho-saito commented Jan 8, 2024

Issue #235, if available:

Description of changes:

In attempting to correct this,
I assume this part

const (
claudePromptFormat = "\n\nHuman:%s\n\nAssistant:"
claudeV2ModelID = "anthropic.claude-v2"
)

could be modified by specifying :1 at the end of claudeV2ModelID as follows

const (
	claudePromptFormat = "\n\nHuman:%s\n\nAssistant:"
	claudeV2ModelID    = "anthropic.claude-v2:1"
)

When I tried the modified one, it actually worked like this

$ ./rain build -p "VPC with 1 private and 1 public subnet"
AWSTemplateFormatVersion: '2010-09-09'
Description: VPC with 1 public and 1 private subnet

Resources:

  VPC:
    Type: AWS::EC2::VPC
    Properties:
      CidrBlock: 10.0.0.0/16
      EnableDnsSupport: true
      EnableDnsHostnames: true
  
  PublicSubnet:
    Type: AWS::EC2::Subnet
    Properties:
      VpcId: !Ref VPC
      CidrBlock: 10.0.1.0/24
      MapPublicIpOnLaunch: true
  
  PrivateSubnet:
    Type: AWS::EC2::Subnet
    Properties: 
      VpcId: !Ref VPC
      CidrBlock: 10.0.2.0/24

reference:
https://docs.aws.amazon.com/bedrock/latest/userguide/model-ids-arns.html#:~:text=anthropic.claude%2Dv2.%20For%20Claude%202.1%2C%20use%20anthropic.claude%2Dv2%3A1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sho-saito sho-saito marked this pull request as ready for review January 8, 2024 08:00
@ericzbeard ericzbeard self-requested a review January 8, 2024 17:45
@ericzbeard ericzbeard merged commit 946dacb into aws-cloudformation:main Jan 8, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants