-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AWS::CodeBuild::Project - Support Batch Builds (From Trigger) #621
Comments
I can include screenshots from the console if that is helpful. |
It's not supported at the moment unfortunately. If you're using the CDK it's possible to create a custom resource using |
Thanks for the tip @tjenkinson ! That seems like it will be adequate until this ticket is worked. |
@wulfmann - Thanks for reporting this issue. Team is working on a fix and will address it in the next week or so. |
just opened #633 which is support for triggering batch builds from codepipeline |
@subinataws any update on this? |
Hello @tjenkinson We have enabled this for projects. This can be used with CloudFormation with the BuildType option, the valid inputs are
We are working on updating or official documentation. Sorry for the confusion. |
That's great thanks. Next step is getting it into the CDK :) |
@johnhanks1 does this setting apply for any trigger or just webhooks? Question from @skinny85 on the cdk PR (aws/aws-cdk#11743 (comment))
|
Found it in the docs now but it says
|
@johnhanks1 would be great to get some clarity on this because it's blocking the CDK PR. Thanks! |
This adds a `startBatchBuild` option to the code build source, to trigger a batch build. The cloudformation property isn't in the official docs yet but is mentioned [here](aws-cloudformation/cloudformation-coverage-roadmap#621 (comment)). Closes #11663
This adds a `startBatchBuild` option to the code build source, to trigger a batch build. The cloudformation property isn't in the official docs yet but is mentioned [here](aws-cloudformation/cloudformation-coverage-roadmap#621 (comment)). Closes aws#11663
Howdy! I attempted to update the codebuild project I am working on that requires batch builds in order to build properly and it seems that its still not executing when I run the buildspec.yml that I declare the batch in. Thanks for any assistance that can be provided. |
Does the config in the console show it's set to the batch mode? |
Managed to get it working.
Thank you for your time though! |
In order for a CodeBuild to run in batch mode, a batch service role is needed, as described [here in the docs](https://docs.aws.amazon.com/codebuild/latest/userguide/batch-build.html). >Batch builds introduce a new security role in the batch configuration. This new role is required as CodeBuild must be able to call the StartBuild, StopBuild, and RetryBuild actions on your behalf to run builds as part of a batch. Customers should use a new role, and not the same role they use in their build... At first I thought lets add this by default, but then I realised when `BatchConfiguration` is set to something, in the aws console the default 'start build' button behaviour changes to start a batch build by default instead :/ So now this adds a new `supportBatchBuildType` option, which when `true` adds minimum amount of `BatchConfiguration` needed for batch builds to run. I also updated the doc blocks for the webhook option and CodePipeline action option, because users of those also need to set this option. It would be nice to auto-enable this if a webhook or CodeBuild action is configured, but that sounds pretty complicated. I'm not sure why anyone would need to customise this role, given it appears to only be used internally to do those 3 things, so this PR does not make it configurable. My thinking is that this could be added later if needed, but this PR just gets batch builds working. In the future if people want control of the other `BatchConfiguration` options I was thinking these could be added and would require `supportBatchBuildType` to be `true`. related: aws-cloudformation/cloudformation-coverage-roadmap#621
Does this work with the local codebuild agent docker image? I can't seem to get it to kick off batch builds thus far. |
This is now supported from CFN and CDK both. |
Thanks for reporting this. We have added a backlog item to assess the feasibility and add batch build support in local codebuild agent. |
1. AWS::CodeBuild::Project - Support Batch Builds
When creating a CodeBuild project there is no way to specify that the webhook trigger should run the project as a 'Batch Build'
2. Scope of request
a) new option for an existing attribute is desired
There is already a webhook option in the project triggers section of the provider, but it is a boolean value. It would seem that support for a new 'BuildType' option should be added.
3. Expected behavior
Allow me to specify a trigger type of STANDARD or BATCH
4. Suggest specific test cases
Samples:
Create a CodeBuild Project with a trigger type of STANDARD
Create a CodeBuild Project with a trigger type of BATCH
5. Helpful Links to speed up research and evaluation
Trigger batch build with cli
6. Category (required)
The text was updated successfully, but these errors were encountered: