Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving logging for Ctv1 #996

Merged
merged 3 commits into from
May 11, 2023
Merged

Conversation

rajdnp
Copy link
Contributor

@rajdnp rajdnp commented May 3, 2023

Issue #, if available:

Description of changes:
Improving logging for Ctv1

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Testing :
Unit testing
Pre-commit hooks are successful

Screenshots :
Error1
Error2
Error3
error4
Error5

Copy link

@joshuadeanhall joshuadeanhall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good but are there no unit tests that we can add to validate the expected behavior?

@rajdnp
Copy link
Contributor Author

rajdnp commented May 5, 2023

The changes look good but are there no unit tests that we can add to validate the expected behavior?

Added more test https://github.com/aws-cloudformation/cloudformation-cli/pull/996/files#diff-56099aed7f1376770c545e5382edc0717d3a93376cb6371f3184f534c2f64b9e

Copy link
Contributor

@mmaeng mmaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kddejong kddejong merged commit 63ace82 into aws-cloudformation:master May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants