Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update configuration for the logging bucket. #986

Conversation

mrinaudo-aws
Copy link
Contributor

Issue #, if available:
Fixes #985

Description of changes:
Update configuration for the logging bucket:

  • use a bucket policy instead of an ACL; see Grant permissions to the logging service principal using a bucket policy in Permissions for log delivery;
  • use AES256 instead of the current SSE-KMS setting for the log bucket; see considerations on the default bucket encryption on the target bucket with AES256 (SSE-S3) in Enabling Amazon S3 server access logging (where I note: You can use default bucket encryption on the target bucket only if you use AES256 (SSE-S3). Default encryption with AWS KMS keys (SSE-KMS) is not supported). I started to see logs in my logs bucket after I changed to AES256 the default bucket encryption for the log bucket itself.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@himanshs23 himanshs23 merged commit d4dfef4 into aws-cloudformation:master Apr 23, 2023
@mrinaudo-aws mrinaudo-aws deleted the update-managed-infra-s3-server-access-logging branch April 23, 2023 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants