Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

specify --profile for cli #874

Conversation

rrhodes
Copy link
Contributor

@rrhodes rrhodes commented Mar 26, 2022

closes #777

Description of changes:
New optional argument --profile to indicate which AWS profile should be used by the CLI for commands submit, invoke, and test.

Testing:
In addition to unit test modifications, the following commands have been manually tested with and without --profile specified:

  • submit module
  • submit hook
  • submit resource

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rrhodes rrhodes marked this pull request as draft March 26, 2022 21:30
@rrhodes rrhodes marked this pull request as ready for review March 29, 2022 17:53
@ammokhov ammokhov added enhancement New feature or request cli experience labels Jun 15, 2022
@ammokhov
Copy link
Contributor

Thanks for the contribution, we should take a look at your pull-request soon and get back

Copy link
Member

@Brianwithay21 Brianwithay21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for HOOK type specific changes look good to me

@rrhodes
Copy link
Contributor Author

rrhodes commented Sep 24, 2022

Hi @Brianwithay21, @MalikAtalla-AWS, anything further required before this is eligible for merging? I don't appear to have permission to merge this.

@MalikAtalla-AWS
Copy link
Contributor

Hey @rrhodes, thanks for the reminder. I'll ping the team who owns this repo.

@rrhodes
Copy link
Contributor Author

rrhodes commented Sep 25, 2022

Hey @rrhodes, thanks for the reminder. I'll ping the team who owns this repo.

No trouble, thanks @MalikAtalla-AWS 🙂

Comment on lines +34 to +37
`--profile <value>`

The AWS profile to use\. If no profile is specified, the client applies credentials specified in the [Boto3 credentials chain](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html)\.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be useful to show how profile should be specified

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind elaborating on this, please? We have the --profile <value> example above on line 34, consistent with other documented options.

Copy link
Contributor

@ericzbeard ericzbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some conflicts with the latest changes on trunk that need to be resolved before we can merge this.

@ericzbeard ericzbeard assigned mmaeng and unassigned ericzbeard Jan 4, 2023
@rrhodes
Copy link
Contributor Author

rrhodes commented Jan 5, 2023

I'll look to resolve these merge conflicts, thanks.

@rrhodes rrhodes requested review from ericzbeard and ammokhov and removed request for ericzbeard and ammokhov January 5, 2023 11:36
@ericzbeard ericzbeard merged commit bd8a2c0 into aws-cloudformation:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli experience enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cfn CLI needs a way to specify --profile
6 participants