-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
specify --profile for cli #874
specify --profile for cli #874
Conversation
Thanks for the contribution, we should take a look at your pull-request soon and get back |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes for HOOK
type specific changes look good to me
Hi @Brianwithay21, @MalikAtalla-AWS, anything further required before this is eligible for merging? I don't appear to have permission to merge this. |
Hey @rrhodes, thanks for the reminder. I'll ping the team who owns this repo. |
No trouble, thanks @MalikAtalla-AWS 🙂 |
`--profile <value>` | ||
|
||
The AWS profile to use\. If no profile is specified, the client applies credentials specified in the [Boto3 credentials chain](https://boto3.amazonaws.com/v1/documentation/api/latest/guide/configuration.html)\. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be useful to show how profile should be specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind elaborating on this, please? We have the --profile <value>
example above on line 34, consistent with other documented options.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some conflicts with the latest changes on trunk that need to be resolved before we can merge this.
I'll look to resolve these merge conflicts, thanks. |
closes #777
Description of changes:
New optional argument
--profile
to indicate which AWS profile should be used by the CLI for commandssubmit
,invoke
, andtest
.Testing:
In addition to unit test modifications, the following commands have been manually tested with and without
--profile
specified:submit
modulesubmit
hooksubmit
resourceBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.