-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add property transform for contract tests #843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjinmei
force-pushed
the
property_transform
branch
from
November 2, 2021 06:13
e6cadc4
to
440353c
Compare
zjinmei
force-pushed
the
property_transform
branch
from
November 10, 2021 07:56
eac8208
to
d350f06
Compare
ammokhov
reviewed
Nov 12, 2021
ammokhov
reviewed
Nov 17, 2021
ammokhov
approved these changes
Nov 17, 2021
omkhegde
approved these changes
Nov 18, 2021
mmaeng
approved these changes
Jan 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
When resource handlers input and output are not equal in contract tests, we can utilize property transform for input model and compare with output model again, if succeed, CT pass, if failed, CT failed
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.