Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add property transform for contract tests #843

Merged
merged 21 commits into from
Jan 6, 2023
Merged

Conversation

zjinmei
Copy link
Contributor

@zjinmei zjinmei commented Oct 29, 2021

Description of changes:
When resource handlers input and output are not equal in contract tests, we can utilize property transform for input model and compare with output model again, if succeed, CT pass, if failed, CT failed

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@zjinmei zjinmei force-pushed the property_transform branch from e6cadc4 to 440353c Compare November 2, 2021 06:13
@zjinmei zjinmei marked this pull request as ready for review November 10, 2021 17:46
@zjinmei zjinmei requested review from ammokhov and omkhegde November 10, 2021 17:46
README.md Outdated Show resolved Hide resolved
src/rpdk/core/contract/resource_client.py Show resolved Hide resolved
src/rpdk/core/contract/suite/handler_commons.py Outdated Show resolved Hide resolved
@ericzbeard ericzbeard removed their assignment Jan 4, 2023
@mmaeng mmaeng merged commit b8f69bb into master Jan 6, 2023
@mmaeng mmaeng deleted the property_transform branch January 6, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants