Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update reqs and fix issues #1030

Merged
merged 3 commits into from
Oct 6, 2023
Merged

Update reqs and fix issues #1030

merged 3 commits into from
Oct 6, 2023

Conversation

kddejong
Copy link
Contributor

@kddejong kddejong commented Oct 6, 2023

Issue #, if available:

Description of changes:

  • Update requirements.txt dependencies and fix corresponding issues found from newer versions of pylint, etc.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@kddejong kddejong force-pushed the lifecycle/requirements/2023/10/06 branch from 85ffa52 to 91522b7 Compare October 6, 2023 21:08
mircealam
mircealam approved these changes Oct 6, 2023
View reviewed changes
Copy link
Member

@mircealam mircealam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

mmaeng
mmaeng approved these changes Oct 6, 2023
View reviewed changes
Copy link
Contributor

@mmaeng mmaeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mircealam mircealam merged commit 5848cc8 into aws-cloudformation:master Oct 6, 2023
9 checks passed
@kddejong kddejong deleted the lifecycle/requirements/2023/10/06 branch October 6, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mircealam mircealam mircealam approved these changes

@mmaeng mmaeng mmaeng approved these changes

@ericzbeard ericzbeard ericzbeard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kddejong @ericzbeard @mmaeng @mircealam