Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate typename prefix is valid when creating ListType request whil… #1022

Merged

Conversation

Brianwithay21
Copy link
Member

…e resolving hook target names

Issue #, if available:

Description of changes:
Updated the TypeNameResolver to validate that the type name prefix used with the TypeFilters field is correct and matches expected regex for parameter

Error message:

botocore.exceptions.ClientError: An error occurred (ValidationError) when calling the ListTypes operation: 1 validation error detected: Value 'A' at 'filters.typeNamePrefix' failed to satisfy constraint: Member must satisfy regular expression pattern: ([A-Za-z0-9]{2,64}::){0,2}([A-Za-z0-9]{2,64}:?){0,1}(:[A-Za-z0-9:]{2,64}){0,1}

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mrinaudo-aws mrinaudo-aws self-requested a review September 22, 2023 16:44
Copy link
Contributor

@mrinaudo-aws mrinaudo-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Brianwithay21 Brianwithay21 merged commit 0526b80 into aws-cloudformation:master Sep 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants