Handler schema definition #1009
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ammokhov
reviewed
Jun 19, 2023
tests/test_data_loaders.py
Outdated
Comment on lines
496
to
498
| @pytest.mark.skip( | ||
| reason="Inline resolver for meta schema is breaking this, disabling for now" | ||
| ) |
There was a problem hiding this comment.
hmm, can you root cause it? dont think we should disable it
benbridts
reviewed
Jul 14, 2023
src/rpdk/core/jsonutils/inliner.py
Outdated
| value[len(self.META_SCHEMA) :] # noqa: E203 | ||
| ) # noqa: E203 | ||
| else: # noqa: E203 | ||
| raise RefResolutionError # noqa: E203 |
There was a problem hiding this comment.
If you write this, you re-raise the original exception, which gives easier debugging
Suggested change
| raise RefResolutionError # noqa: E203 | |
| raise |
kddejong
reviewed
Jul 28, 2023
| @@ -4,6 +4,55 @@ | |||
| "title": "CloudFormation Resource Provider Definition MetaSchema", | |||
| "description": "This schema validates a CloudFormation resource provider definition.", | |||
| "definitions": { | |||
| "handlerSchema": { | |||
There was a problem hiding this comment.
Whats the difference between this and one linked in this github action? Should we be updating that file instead? Which one is the source?
There was a problem hiding this comment.
I am not sure what is the difference. @ammokhov do you know?
But I do know that to actually support using this, we need to the change to inliner.py.
ammokhov
approved these changes
Jul 31, 2023
sgathili
approved these changes
Jul 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.