Skip to content

Commit

Permalink
Add in no-docker and use-docker override to submit command (#970)
Browse files Browse the repository at this point in the history
* Add in no-docker and use-docker override to submit command

* Remove reference to TypeScript

* Updated comment to be accurate about config file
  • Loading branch information
mmaeng authored May 4, 2023
1 parent 6d42100 commit b907697
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions src/rpdk/core/submit.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@
def submit(args):
project = Project()
project.load()
# Use CLI override opposed to config file if use-docker or no-docker switch used
if args.use_docker or args.no_docker:
project.settings["use_docker"] = args.use_docker
project.settings["no_docker"] = args.no_docker
project.submit(
args.dry_run,
args.endpoint_url,
Expand Down Expand Up @@ -51,3 +55,18 @@ def setup_subparser(subparsers, parents):
help="Register the type without an explicit execution role "
"(Will not be able to invoke AWS APIs).",
)

nodocker_group = parser.add_mutually_exclusive_group()
nodocker_group.add_argument(
"--use-docker",
action="store_true",
help="""Use docker for platform-independent packaging.
This is highly recommended unless you are experienced
with cross-platform packaging.""",
)
nodocker_group.add_argument(
"--no-docker",
action="store_true",
help="""Generally not recommended unless you are experienced
with cross-platform packaging.""",
)

0 comments on commit b907697

Please sign in to comment.