Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for python 3.8 and 3.9, switched docker image to mlupin/docker-lambda #176

Closed
wants to merge 2 commits into from
Closed

Add support for python 3.8 and 3.9, switched docker image to mlupin/docker-lambda #176

wants to merge 2 commits into from

Conversation

mumblepins
Copy link
Contributor

Description of changes:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mumblepins mumblepins mentioned this pull request Mar 18, 2022
Closed
@mumblepins
Copy link
Contributor Author

Sister pull request aws-cloudformation/cloudformation-cli#870

ammokhov
ammokhov requested changes Aug 17, 2022
View reviewed changes
Copy link
Contributor

@ammokhov ammokhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually to make it 100% backward compatible, lets release cli first and add install requirements to python plugin

install_requires=["cloudformation-cli>=0.2.24", "types-dataclasses>=0.1.5"]

ref

@ericzbeard ericzbeard assigned ericzbeard and kddejong and unassigned ericzbeard Oct 13, 2022
@ericzbeard ericzbeard mentioned this pull request Oct 13, 2022
Closed
@ericzbeard
Copy link

We are going to make a few changes to this PR. We changed the docker image to one hosted in ECR in a PR we merged earlier.

@kddejong don't forget to incorporate changes from #145

@kddejong
Copy link
Contributor

Closed for replacement by #198

@kddejong kddejong closed this Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammokhov ammokhov ammokhov requested changes

@prerna-p prerna-p prerna-p approved these changes

Assignees

@kddejong kddejong

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mumblepins @ericzbeard @kddejong @prerna-p @ammokhov