Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run data snippets through prettier, naming updates #7827

Merged

Conversation

josefaidt
Copy link
Contributor

Description of changes:

taking a pass at consolidating snippet code styles and headings for js/ts snippets, namely:

  • running snippets through prettier for spacing
  • adding snippet titles as necessary
  • reworking override snippet ergonomics to align with others

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt changed the title run snippets through prettier, naming updates run data snippets through prettier, naming updates Jul 16, 2024
@josefaidt josefaidt marked this pull request as ready for review July 22, 2024 23:18
@josefaidt josefaidt requested a review from a team as a code owner July 22, 2024 23:18
@josefaidt josefaidt requested review from AnilMaktala, chrisbonifacio and a team July 22, 2024 23:18
@chrisbonifacio
Copy link
Member

LGTM!

@josefaidt josefaidt enabled auto-merge (squash) October 14, 2024 23:10
@josefaidt josefaidt merged commit d593c37 into aws-amplify:main Oct 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants