Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add confirm sign in snippet #7782 #7787

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

josefaidt
Copy link
Contributor

@josefaidt josefaidt commented Jun 27, 2024

Description of changes:

adds snippet for confirming sign in

Related GitHub issue #, if available:

closes #7782

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@josefaidt josefaidt marked this pull request as ready for review July 1, 2024 19:00
@josefaidt josefaidt requested a review from a team as a code owner July 1, 2024 19:00
Copy link

@sameer-dudeja sameer-dudeja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, For future specific code for angular or react native could be there but its a minor/ semantic change. The function conveys the overall process.

Copy link
Member

@cwomack cwomack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josefaidt josefaidt merged commit 5691d81 into aws-amplify:main Aug 28, 2024
11 checks passed
@josefaidt josefaidt deleted the add-confirm-sign-in-snippet branch August 28, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confirm Sign Docs are Missing
4 participants