-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vue): Update data setup guide for Vue, remove tsx #7727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josefaidt
reviewed
Jun 28, 2024
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 28, 2024
<button @click="createTodo">Add new todo</button> | ||
</div> | ||
</template> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
reviewed
Jun 28, 2024
src/pages/[platform]/build-a-backend/data/set-up-data/index.mdx
Outdated
Show resolved
Hide resolved
josefaidt
approved these changes
Jul 26, 2024
chrisbonifacio
approved these changes
Sep 4, 2024
reesscot
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
The data setup guide for Vue is not correct. It shows React code instead of Vue code.
Related GitHub issue #, if available:
Fixes #7622
Instructions
If this PR should not be merged upon approval for any reason, please submit as a DRAFT
Which platform(s) are affected by this PR (if applicable)?
Please add the product(s)/platform(s) affected to the PR title
Checks
Does this PR conform to the styleguide?
Are all links in MDX files using the MDX link syntax rather than HTML link syntax?
ref: MDX:
[link](https://docs.amplify.aws/)
HTML:
<a href="https://docs.amplify.aws/">link</a>
When this PR is ready to merge, please check the box below
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.