Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vue): Update data setup guide for Vue, remove tsx #7727

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

ErikCH
Copy link
Contributor

@ErikCH ErikCH commented Jun 7, 2024

Description of changes:

The data setup guide for Vue is not correct. It shows React code instead of Vue code.

Related GitHub issue #, if available:

Fixes #7622

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ErikCH ErikCH requested a review from a team as a code owner June 7, 2024 21:45
<button @click="createTodo">Add new todo</button>
</div>
</template>

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@ErikCH ErikCH requested a review from josefaidt July 26, 2024 21:20
@chrisbonifacio chrisbonifacio enabled auto-merge (squash) September 4, 2024 20:25
@chrisbonifacio chrisbonifacio merged commit 19e99c4 into main Sep 4, 2024
12 checks passed
@chrisbonifacio chrisbonifacio deleted the vue-fix-build-a-backend branch September 4, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vue documentation importing React?
4 participants