Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note for using structured types with functions #3128

Merged
merged 2 commits into from
May 28, 2021
Merged

Add note for using structured types with functions #3128

merged 2 commits into from
May 28, 2021

Conversation

camerondurham
Copy link
Contributor

@camerondurham camerondurham commented Apr 10, 2021

Description of changes:

Added a note to relevant Lambda documentation and pointed out requirements for using typed event input.

As a first-time Lambda, I was unfamiliar with the expected input format for these functions. This note adds a link to the relevant Lambda documentation. While the examples in this document are helpful for the general expected design, it is difficult to understand the important parts required to implement a correct lambda resolver for a GraphQL function. I added the note to help other developers using more strongly typed languages such as Golang, Java, and C# should they encounter this error.

Thank you for considering this change!

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
As a first-time Lambda, I was unfamiliar with the expected input format for these functions. This note adds a link to the relevant Lambda documentation. While the examples in this document are helpful for the general expected design, it is difficult to understand the important parts required to implement a correct lambda resolver for a GraphQL function. I added the note to help other developers using more strongly typed languages such as Golang, Java, and C# should they encounter this error.

Thank you for considering this change!
@camerondurham camerondurham requested a review from a team as a code owner April 10, 2021 03:58
@palpatim palpatim added the amplify/cli Issues tied to CLI label Apr 12, 2021
@tjleing tjleing changed the base branch from master to main April 15, 2021 14:49
Copy link
Contributor

@akshbhu akshbhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the Contribution
LGTM!!

@camerondurham
Copy link
Contributor Author

@akshbhu Thanks for reviewing! From these docs, you may or may not have to manually kick off the CI to run, since it looks like a check isn't run yet?

Sorry if this doesn't apply to how you do CI on this repo.

@medelman17 medelman17 self-assigned this May 25, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@medelman17 medelman17 merged commit 362fbab into aws-amplify:main May 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
amplify/cli Issues tied to CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants