Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix inappmessaging ts strict errors #3413

Merged
merged 1 commit into from
Feb 13, 2023
Merged

Conversation

reesscot
Copy link
Contributor

Description of changes

Fixes the final TS Strict error in InAppMessaging!

Issue #, if available

Description of how you validated changes

Checklist

  • PR description included
  • yarn test passes
  • Tests are updated
  • No side effects or sideEffects field updated
  • Relevant documentation is changed or added (and PR referenced)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@reesscot reesscot requested a review from a team as a code owner February 10, 2023 21:20
@changeset-bot
Copy link

changeset-bot bot commented Feb 10, 2023

⚠️ No Changeset found

Latest commit: 6908e50

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@reesscot reesscot temporarily deployed to ci February 10, 2023 21:38 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 10, 2023 21:38 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 10, 2023 21:38 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 10, 2023 21:38 — with GitHub Actions Inactive
dbanksdesign
dbanksdesign previously approved these changes Feb 10, 2023
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

ioanabrooks
ioanabrooks previously approved these changes Feb 10, 2023
@reesscot reesscot closed this Feb 13, 2023
@reesscot reesscot force-pushed the reesscot-ts-strict-9 branch from 7b6ffe3 to 56947bc Compare February 13, 2023 16:33
@reesscot reesscot deleted the reesscot-ts-strict-9 branch February 13, 2023 16:35
@reesscot reesscot reopened this Feb 13, 2023
@reesscot reesscot dismissed stale reviews from ioanabrooks and dbanksdesign via 6908e50 February 13, 2023 16:38
Copy link
Member

@calebpollman calebpollman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@reesscot reesscot temporarily deployed to ci February 13, 2023 16:56 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 13, 2023 16:57 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 13, 2023 16:57 — with GitHub Actions Inactive
@reesscot reesscot temporarily deployed to ci February 13, 2023 16:57 — with GitHub Actions Inactive
Copy link
Contributor

@dbanksdesign dbanksdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@reesscot reesscot merged commit f247472 into main Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants