chore(test): add integration test cases of CPK for API lazy loading #2769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5d
force-pushed
the
5d/ll12-subscription-integration-test-more
branch
from
a0d2288
to
301268b
Compare
5d
changed the base branch from
main
to
5d/ll12-subscription-integration-test
5d
force-pushed
the
5d/ll12-subscription-integration-test-more
branch
from
301268b
to
de53bfc
Compare
Base automatically changed from
5d/ll12-subscription-integration-test
to
main
February 17, 2023 22:11
5d
force-pushed
the
5d/ll12-subscription-integration-test-more
branch
from
de53bfc
to
dd09f50
Compare
| @@ -17,82 +17,82 @@ final class GraphQLLazyLoadHasOneTests: GraphQLLazyLoadBaseTest { | |||
| func testConfigure() async throws { | |||
| await setup(withModels: HasOneParentChildModels()) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this file can be reverted if only whitespace changes.
| @@ -17,86 +17,86 @@ final class GraphQLLazyLoadDefaultPKTests: GraphQLLazyLoadBaseTest { | |||
| func testConfigure() async throws { | |||
| await setup(withModels: DefaultPKModels()) | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this file can be reverted if only whitespace changes.
|
|
||
| try await mutate(.create(parent)) | ||
| try await mutate(.create(child)) | ||
| try await mutate(.update(child)) |
There was a problem hiding this comment.
will this call the update mutation event even if there are no changes to child model?
|
|
||
| try await mutate(.create(parent)) | ||
| try await mutate(.create(child)) | ||
| await waitForExpectations([onCreate], timeout: 10) |
There was a problem hiding this comment.
It'd be great if we can we use a constant for timeout value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Description
General Checklist
Security oriented best practices and standards are followed (e.g. using input sanitization, principle of least privilege, etc)Given When Theninline code documentation and are named accordinglytestThing_condition_expectation()If breaking change, documentation/changelog update with migration instructionsBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.