-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@aws-amplify/datastore): fix hasOne delete #8191
Conversation
Codecov Report
@@ Coverage Diff @@
## main #8191 +/- ##
==========================================
+ Coverage 76.90% 76.91% +0.01%
==========================================
Files 233 233
Lines 15222 15228 +6
Branches 2975 2979 +4
==========================================
+ Hits 11706 11713 +7
+ Misses 3289 3288 -1
Partials 227 227
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🎉
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes
Allow deleting records that have a Has One relation. Perform a cascading delete.
Note: This library bugfix relies on a recent Codegen change, and in order to work correctly, this feature flag needs to be set to
true
. Starting 5/1 this will be the default CLI/Codegen behavior for new projects.Issue #, if available
#6560
Description of how you validated changes
Checklist
yarn test
passesRelevant documentation is changed or added (and PR referenced)N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.