-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add amazon-cognito-identity-js tests to CircleCI #6551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't recall if this job runs for PRs (thinking no), but I'm down to merge this once tests pass 🙏
Codecov Report
@@ Coverage Diff @@
## main #6551 +/- ##
=======================================
Coverage 73.26% 73.26%
=======================================
Files 208 208
Lines 12920 12920
Branches 2432 2525 +93
=======================================
Hits 9466 9466
+ Misses 3291 3263 -28
- Partials 163 191 +28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
* add amazon-cognito-identity-js tests to CCI
* add amazon-cognito-identity-js tests to CCI
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
Add initial
amazon-cognito-identity-js
integration tests to CircleCI.Successful test run: https://app.circleci.com/pipelines/github/aws-amplify/amplify-js/5785/workflows/af8895dc-9891-4434-be4e-af7d2099321d/jobs/19521
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.