-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for opened notifications in iOS #5835
Adding support for opened notifications in iOS #5835
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5835 +/- ##
=======================================
Coverage 73.75% 73.75%
=======================================
Files 204 204
Lines 11973 11973
Branches 2342 2254 -88
=======================================
Hits 8831 8831
- Misses 2960 2980 +20
+ Partials 182 162 -20
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested and was able to receive onNotificationOpened
callback both when the app is in the background as well as completely killed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🌮
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
Description of changes:
Adding support for opened notifications in iOS
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.