-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(aws-amplify): add DataStore export #5421
fix(aws-amplify): add DataStore export #5421
Conversation
@@ -46,5 +46,47 @@ | |||
"@aws-amplify/storage": "^3.1.6", | |||
"@aws-amplify/ui": "^2.0.2", | |||
"@aws-amplify/xr": "^2.1.6" | |||
}, | |||
"jest": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Borrowed this config from @aws-amplify/auth
.
"API", | ||
"APIClass", | ||
"graphqlOperation", | ||
"DataStore", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added via a07e0ac
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export * from '@aws-amplify/ui';
in index.ts of aws-amplify
Codecov Report
@@ Coverage Diff @@
## master #5421 +/- ##
=======================================
Coverage 72.91% 72.91%
=======================================
Files 196 196
Lines 11490 11490
Branches 2240 2162 -78
=======================================
Hits 8378 8378
- Misses 2942 2961 +19
+ Partials 170 151 -19
Continue to review full report at Codecov.
|
@manueliglesias Let me know if there are any other exports we should add from The only ones remaining would be TypeScript types or enums, but those are directly available via |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 🎉
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
With v3 (modularization) merged, there was a miss with #5202 exporting
{ DataStore}
.This PR corrects this so customers can use:
I've added test coverage for our current exports (e.g.
import *
) which is shockingly large.There are clearly mistakes (e.g.
a
) that shouldn't be exported that we are likely unaware of.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.