Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clientMetadata to sendMFACode #5145

Merged
merged 2 commits into from
Mar 27, 2020
Merged

Added clientMetadata to sendMFACode #5145

merged 2 commits into from
Mar 27, 2020

Conversation

mk0sojo
Copy link
Contributor

@mk0sojo mk0sojo commented Mar 19, 2020

_Issue #5144

_Description of changes: Added clientMetadata to sendMFACode typescript definition

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #5145 into master will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5145   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files         193      193           
  Lines       11450    11450           
  Branches     2305     2305           
=======================================
  Hits         8379     8379           
  Misses       2907     2907           
  Partials      164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23d8d41...1c241bb. Read the comment docs.

@ericclemmons ericclemmons linked an issue Mar 23, 2020 that may be closed by this pull request
Copy link
Contributor

@ericclemmons ericclemmons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

This looks good, and is consistent with the function signature:

/**
* This is used by the user once he has an MFA code
* @param {string} confirmationCode The MFA code entered by the user.
* @param {object} callback Result callback map.
* @param {string} mfaType The mfa we are replying to.
* @param {onFailure} callback.onFailure Called on any error.
* @param {authSuccess} callback.onSuccess Called on success with the new session.
* @param {ClientMetadata} clientMetadata object which is passed from client to Cognito Lambda trigger
* @returns {void}
*/
sendMFACode(confirmationCode, callback, mfaType, clientMetadata) {

public sendMFACode(
confirmationCode: string,
callbacks: {
onSuccess: (session: CognitoUserSession) => void;
onFailure: (err: any) => void;
},
mfaType?: string,
clientMetadata?: ClientMetadata
): void;

@manueliglesias manueliglesias merged commit d630c34 into aws-amplify:master Mar 27, 2020
This was referenced Jan 14, 2021
@github-actions
Copy link

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

type script definition for sendMFACode is incorrect
3 participants