-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added clientMetadata to sendMFACode #5145
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5145 +/- ##
=======================================
Coverage 73.17% 73.17%
=======================================
Files 193 193
Lines 11450 11450
Branches 2305 2305
=======================================
Hits 8379 8379
Misses 2907 2907
Partials 164 164 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
This looks good, and is consistent with the function signature:
amplify-js/packages/amazon-cognito-identity-js/src/CognitoUser.js
Lines 836 to 846 in 4531dd9
/** | |
* This is used by the user once he has an MFA code | |
* @param {string} confirmationCode The MFA code entered by the user. | |
* @param {object} callback Result callback map. | |
* @param {string} mfaType The mfa we are replying to. | |
* @param {onFailure} callback.onFailure Called on any error. | |
* @param {authSuccess} callback.onSuccess Called on success with the new session. | |
* @param {ClientMetadata} clientMetadata object which is passed from client to Cognito Lambda trigger | |
* @returns {void} | |
*/ | |
sendMFACode(confirmationCode, callback, mfaType, clientMetadata) { |
amplify-js/packages/amazon-cognito-identity-js/index.d.ts
Lines 149 to 157 in 4531dd9
public sendMFACode( | |
confirmationCode: string, | |
callbacks: { | |
onSuccess: (session: CognitoUserSession) => void; | |
onFailure: (err: any) => void; | |
}, | |
mfaType?: string, | |
clientMetadata?: ClientMetadata | |
): void; |
This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs. Looking for a help forum? We recommend joining the Amplify Community Discord server |
_Issue #5144
_Description of changes: Added clientMetadata to sendMFACode typescript definition
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.