fix(adapter-nextjs): duplicate response Set-Cookie headers in pages router #13765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HuiSF
requested review from
ukhan-amazon,
haverchuck,
cshfang and
jimblanc
as code owners
ashika112
reviewed
Aug 28, 2024
| Array.isArray(existingSetCookieValues) && | ||
| existingSetCookieValues.findIndex( | ||
| cookieValue => | ||
| cookieValue.startsWith(`${encodedName}=`) && |
There was a problem hiding this comment.
naive question: why not just check startsWith(`${encodedName}=${value};`) here?
There was a problem hiding this comment.
As value may change when there were back to back token refreshes happened, e.g. a request going through the middleware and the page and tokens were being refreshed in both places. In this case we keep the very first refresh.
HuiSF
force-pushed
the
hui/fix/adapter-nextjs/pages-cookies
branch
2 times, most recently
from
df00288 to
2ec0b64
Compare
atierian
approved these changes
Aug 29, 2024
ashika112
approved these changes
Aug 29, 2024
AllanZhengYP
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixing duplicate Set-Cookie header may be added with in Next.js Page Router.
Issue #, if available
Description of how you validated changes
Checklist
yarn testpassesChecklist for repo maintainers
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.